debug: added new connection cache output, plus fixups

Debug output 'typo' fix.

Don't print an extra "0x" in
  * Pipe broke: handle 0x0x2546d88, url = /

Add debug output.
Print the number of connections in the connection cache when
  adding one, and not only when one is removed.

Fix typos in comments.

diff --git a/lib/conncache.c b/lib/conncache.c
index 9522aeb10a0b8fdb6f7a0df3318bfa99c57f2b24..d07718e83711af2468ecc83f7a44699d618e8b32 100644 (file)
--- a/lib/conncache.c
+++ b/lib/conncache.c
@@ -152,6 +152,10 @@ CURLcode Curl_conncache_add_conn(struct conncache *connc,
   conn->connection_id = connc->next_connection_id++;
   connc->num_connections++;
 
+  DEBUGF(infof(conn->data, "Added connection %d. "
+               "The cache now contains %d members\n",
+               conn->connection_id, connc->num_connections));
+
   return CURLE_OK;
 }
 

diff --git a/lib/connect.c b/lib/connect.c
index 3a1bc2df7df6868869bcc50ea0ea76b4b697b840..5f64afab3552c08529de880a3a41364de178ac76 100644 (file)
--- a/lib/connect.c
+++ b/lib/connect.c
@@ -1326,7 +1326,7 @@ CURLcode Curl_socket(struct connectdata *conn,
 #ifdef CURLDEBUG
 /*
  * Curl_conncontrol() is used to set the conn->bits.close bit on or off. It
- * MUST be called with the connclose() or connclose() macros with a stated
+ * MUST be called with the connclose() or connkeep() macros with a stated
  * reason. The reason is only shown in debug builds but helps to figure out
  * decision paths when connections are or aren't re-used as expected.
  */

diff --git a/lib/multi.c b/lib/multi.c
index 080e54bce4a2ad1f58f3f5d7612db62fb66d27ee..6313ba4aeb088774857b77e67f1299638c6fa5fb 100644 (file)
--- a/lib/multi.c
+++ b/lib/multi.c
@@ -524,7 +524,7 @@ CURLMcode curl_multi_remove_handle(CURLM *multi_handle,
        connection. */
     connclose(data->easy_conn, "Removed with partial response");
     /* Set connection owner so that Curl_done() closes it.
-       We can sefely do this here since connection is killed. */
+       We can safely do this here since connection is killed. */
     data->easy_conn->data = easy;
     easy_owns_conn = TRUE;
   }
@@ -944,7 +944,7 @@ static CURLMcode multi_runsingle(struct Curl_multi *multi,
     /* Handle the case when the pipe breaks, i.e., the connection
        we're using gets cleaned up and we're left with nothing. */
     if(data->state.pipe_broke) {
-      infof(data, "Pipe broke: handle 0x%p, url = %s\n",
+      infof(data, "Pipe broke: handle %p, url = %s\n",
             (void *)data, data->state.path);
 
       if(data->mstate < CURLM_STATE_COMPLETED) {