]> granicus.if.org Git - graphviz/commitdiff
make final Pylint step fail for any non-FIXME warning/error
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 4 Sep 2021 16:50:03 +0000 (09:50 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Thu, 9 Sep 2021 02:16:32 +0000 (19:16 -0700)
The gating Pylint check now fails if any warning or error is detected, excluding
FIXME comments. This should hopefully lead to improved code quality in Python
introduced into the code base in future.

.gitlab-ci.yml

index f4596a1041c7fd071017837d4892a154d84d0389..2f50a49588273c79b9c30c9dff8c7e9019ef8db8 100644 (file)
@@ -1141,7 +1141,7 @@ lint_pylint:
     - echo "$CI_JOB_NAME-warnings `egrep -c '\<[CRWEF][[:digit:]]{4}\>' $logfile`" > metrics.txt
     - rm $logfile
     - cat metrics.txt
-    - python3 -m pylint --errors-only --rcfile=.pylintrc `find . -name '*.py' | xargs`
+    - python3 -m pylint --rcfile=.pylintrc --disable=fixme `find . -name '*.py' | xargs`
   artifacts:
     when: on_success
     expire_in: 1 week