patch 7.4.989

Problem:    Leaking memory when hash_add() fails. Coverity error 99126.
Solution:   When hash_add() fails free the memory.

diff --git a/src/eval.c b/src/eval.c
index a2d2939ba236f615e232c2fd954871a7bed8c9bc..eca8224ebf0e12686ed1f4b31fae5eacadaee1be 100644 (file)
--- a/src/eval.c
+++ b/src/eval.c
@@ -23095,7 +23095,11 @@ ex_function(eap)
 
        /* insert the new function in the function list */
        STRCPY(fp->uf_name, name);
-       hash_add(&func_hashtab, UF2HIKEY(fp));
+       if (hash_add(&func_hashtab, UF2HIKEY(fp)) == FAIL)
+       {
+           vim_free(fp);
+           goto erret;
+       }
     }
     fp->uf_args = newargs;
     fp->uf_lines = newlines;

diff --git a/src/version.c b/src/version.c
index fcc22cd846acb744e28d7153884922f18fa3a9ba..ddf260bbfd374fda773f8994ce7190cf957115ad 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -741,6 +741,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    989,
 /**/
     988,
 /**/