]> granicus.if.org Git - llvm/commitdiff
Fix warning in ObjectTransformLayerTest.
authorJustin Lebar <jlebar@google.com>
Wed, 13 Jul 2016 18:27:49 +0000 (18:27 +0000)
committerJustin Lebar <jlebar@google.com>
Wed, 13 Jul 2016 18:27:49 +0000 (18:27 +0000)
Doing "I++" inside of an EXPECT_* triggers

  warning: expression with side effects has no effect in an unevaluated context

because EXPECT_* partially expands to

  EqHelper<(sizeof(::testing::internal::IsNullLiteralHelper(MockObjects[I++] + 1)) == 1)>

which is an unevaluated context.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@275293 91177308-0d34-0410-b5e6-96231b3b80d8

unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp

index 908dba11e29a1a1517e77340c48dd090bf7c1b26..e1b1f2f927815c5249fd9d957eef0fca6dba3b9b 100644 (file)
@@ -62,7 +62,8 @@ public:
     EXPECT_EQ(MockResolver, *Resolver) << "Resolver should pass through";
     size_t I = 0;
     for (auto &ObjPtr : Objects) {
-      EXPECT_EQ(MockObjects[I++] + 1, *ObjPtr) << "Transform should be applied";
+      EXPECT_EQ(MockObjects[I] + 1, *ObjPtr) << "Transform should be applied";
+      I++;
     }
     EXPECT_EQ(MockObjects.size(), I) << "Number of objects should match";
     LastCalled = "addObjectSet";