* libmisc/log.c: Add brackets and parenthesis.
* libmisc/log.c: read() returns a ssize_t (note size_t).
* libmisc/log.c: Avoid implicit conversion of pointers to
booleans.
* libmisc/log.c: Ignore return value of time() when use with a
non NULL argument.
+2008-06-13 Nicolas François <nicolas.francois@centraliens.net>
+
+ * libmisc/log.c: Avoid assignments in comparisons.
+ * libmisc/log.c: Add brackets and parenthesis.
+ * libmisc/log.c: read() returns a ssize_t (note size_t).
+ * libmisc/log.c: Avoid implicit conversion of pointers to
+ booleans.
+ * libmisc/log.c: Ignore return value of time() when use with a
+ non NULL argument.
+
2008-06-13 Nicolas François <nicolas.francois@centraliens.net>
* libmisc/strtoday.c: Avoid implicit conversion of pointers to
2008-06-13 Nicolas François <nicolas.francois@centraliens.net>
* libmisc/strtoday.c: Avoid implicit conversion of pointers to
* If the file does not exist, don't create it.
*/
* If the file does not exist, don't create it.
*/
- if ((fd = open (LASTLOG_FILE, O_RDWR)) == -1)
+ fd = open (LASTLOG_FILE, O_RDWR);
+ if (-1 == fd) {
/*
* The file is indexed by UID number. Seek to the record
/*
* The file is indexed by UID number. Seek to the record
* the way we read the old one in.
*/
* the way we read the old one in.
*/
- if (read (fd, (char *) &newlog, sizeof newlog) != sizeof newlog)
+ if (read (fd, (char *) &newlog, sizeof newlog) != (ssize_t) sizeof newlog) {
memzero (&newlog, sizeof newlog);
memzero (&newlog, sizeof newlog);
ll_time = newlog.ll_time;
ll_time = newlog.ll_time;
+ (void) time (&ll_time);
newlog.ll_time = ll_time;
strncpy (newlog.ll_line, line, sizeof newlog.ll_line);
#if HAVE_LL_HOST
strncpy (newlog.ll_host, host, sizeof newlog.ll_host);
#endif
newlog.ll_time = ll_time;
strncpy (newlog.ll_line, line, sizeof newlog.ll_line);
#if HAVE_LL_HOST
strncpy (newlog.ll_host, host, sizeof newlog.ll_host);
#endif
- if (lseek (fd, offset, SEEK_SET) == offset)
+ if (lseek (fd, offset, SEEK_SET) == offset) {
write (fd, (char *) &newlog, sizeof newlog);
write (fd, (char *) &newlog, sizeof newlog);