If walsender has xmin of standby then ensure we
reset the value to 0 when we change from hot_standby_feedback=on
to hot_standby_feedback=off.
</term>
<listitem>
<para>
</term>
<listitem>
<para>
- The standby's current xmin. This may be 0, if the standby does not
- support feedback, or is not yet in Hot Standby state.
+ The standby's current xmin. This may be 0, if the standby is
+ sending notification that Hot Standby feedback will no longer
+ be sent on this connection. Later non-zero messages may
+ reinitiate the feedback mechanism.
</para>
</listitem>
</varlistentry>
</para>
</listitem>
</varlistentry>
#include <unistd.h>
#include "access/timeline.h"
#include <unistd.h>
#include "access/timeline.h"
+#include "access/transam.h"
#include "access/xlog_internal.h"
#include "libpq/pqformat.h"
#include "libpq/pqsignal.h"
#include "access/xlog_internal.h"
#include "libpq/pqformat.h"
#include "libpq/pqsignal.h"
static void XLogWalRcvWrite(char *buf, Size nbytes, XLogRecPtr recptr);
static void XLogWalRcvFlush(bool dying);
static void XLogWalRcvSendReply(bool force, bool requestReply);
static void XLogWalRcvWrite(char *buf, Size nbytes, XLogRecPtr recptr);
static void XLogWalRcvFlush(bool dying);
static void XLogWalRcvSendReply(bool force, bool requestReply);
-static void XLogWalRcvSendHSFeedback(void);
+static void XLogWalRcvSendHSFeedback(bool immed);
static void ProcessWalSndrMessage(XLogRecPtr walEnd, TimestampTz sendTime);
/* Signal handlers */
static void ProcessWalSndrMessage(XLogRecPtr walEnd, TimestampTz sendTime);
/* Signal handlers */
{
got_SIGHUP = false;
ProcessConfigFile(PGC_SIGHUP);
{
got_SIGHUP = false;
ProcessConfigFile(PGC_SIGHUP);
+ XLogWalRcvSendHSFeedback(true);
}
/* Wait a while for data to arrive */
}
/* Wait a while for data to arrive */
}
XLogWalRcvSendReply(requestReply, requestReply);
}
XLogWalRcvSendReply(requestReply, requestReply);
- XLogWalRcvSendHSFeedback();
+ XLogWalRcvSendHSFeedback(false);
/*
* Send hot standby feedback message to primary, plus the current time,
* in case they don't have a watch.
/*
* Send hot standby feedback message to primary, plus the current time,
* in case they don't have a watch.
+ *
+ * If the user disables feedback, send one final message to tell sender
+ * to forget about the xmin on this standby.
-XLogWalRcvSendHSFeedback(void)
+XLogWalRcvSendHSFeedback(bool immed)
{
TimestampTz now;
TransactionId nextXid;
uint32 nextEpoch;
TransactionId xmin;
static TimestampTz sendTime = 0;
{
TimestampTz now;
TransactionId nextXid;
uint32 nextEpoch;
TransactionId xmin;
static TimestampTz sendTime = 0;
+ static bool master_has_standby_xmin = false;
/*
* If the user doesn't want status to be reported to the master, be sure
* to exit before doing anything at all.
*/
/*
* If the user doesn't want status to be reported to the master, be sure
* to exit before doing anything at all.
*/
- if (wal_receiver_status_interval <= 0 || !hot_standby_feedback)
+ if ((wal_receiver_status_interval <= 0 || !hot_standby_feedback) &&
+ !master_has_standby_xmin)
return;
/* Get current timestamp. */
now = GetCurrentTimestamp();
return;
/* Get current timestamp. */
now = GetCurrentTimestamp();
- /*
- * Send feedback at most once per wal_receiver_status_interval.
- */
- if (!TimestampDifferenceExceeds(sendTime, now,
+ if (!immed)
+ {
+ /*
+ * Send feedback at most once per wal_receiver_status_interval.
+ */
+ if (!TimestampDifferenceExceeds(sendTime, now,
wal_receiver_status_interval * 1000))
wal_receiver_status_interval * 1000))
- return;
- sendTime = now;
+ return;
+ sendTime = now;
+ }
/*
* If Hot Standby is not yet active there is nothing to send. Check this
* after the interval has expired to reduce number of calls.
*/
if (!HotStandbyActive())
/*
* If Hot Standby is not yet active there is nothing to send. Check this
* after the interval has expired to reduce number of calls.
*/
if (!HotStandbyActive())
+ {
+ Assert(!master_has_standby_xmin);
/*
* Make the expensive call to get the oldest xmin once we are certain
* everything else has been checked.
*/
/*
* Make the expensive call to get the oldest xmin once we are certain
* everything else has been checked.
*/
- xmin = GetOldestXmin(true, false);
+ if (hot_standby_feedback)
+ xmin = GetOldestXmin(true, false);
+ else
+ xmin = InvalidTransactionId;
/*
* Get epoch and adjust if nextXid and oldestXmin are different sides of
/*
* Get epoch and adjust if nextXid and oldestXmin are different sides of
pq_sendint(&reply_message, xmin, 4);
pq_sendint(&reply_message, nextEpoch, 4);
walrcv_send(reply_message.data, reply_message.len);
pq_sendint(&reply_message, xmin, 4);
pq_sendint(&reply_message, nextEpoch, 4);
walrcv_send(reply_message.data, reply_message.len);
+ if (TransactionIdIsValid(xmin))
+ master_has_standby_xmin = true;
+ else
+ master_has_standby_xmin = false;
feedbackXmin,
feedbackEpoch);
feedbackXmin,
feedbackEpoch);
- /* Ignore invalid xmin (can't actually happen with current walreceiver) */
+ /* Unset WalSender's xmin if the feedback message value is invalid */
if (!TransactionIdIsNormal(feedbackXmin))
if (!TransactionIdIsNormal(feedbackXmin))
+ {
+ MyPgXact->xmin = InvalidTransactionId;
/*
* Check that the provided xmin/epoch are sane, that is, not in the future
/*
* Check that the provided xmin/epoch are sane, that is, not in the future