]> granicus.if.org Git - postgresql/commit
Avoid failure when selecting a namespace node in XMLTABLE. REL_10_STABLE github/REL_10_STABLE
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 25 Oct 2019 19:22:40 +0000 (15:22 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 25 Oct 2019 19:22:40 +0000 (15:22 -0400)
commit9bf24768664be6faf79333e1d4d6d14a0d33587b
tree7be70660be36e396038357ff72a1f5ee8a6fb8c2
parent84d1c5c45fd2d47c4d769ecc45210572a9bbb8f6
Avoid failure when selecting a namespace node in XMLTABLE.

It appears that libxml2 doesn't bother to set the "children" field of
an XML_NAMESPACE_DECL node to null; that field just contains garbage.
In v10 and v11, this can result in a crash in XMLTABLE().  The rewrite
done in commit 251cf2e27 fixed this, somewhat accidentally, in v12.
We're not going to back-patch 251cf2e27, however.  The case apparently
doesn't have wide use, so rather than risk introducing other problems,
just add a safety check to throw an error.

Even though no bug manifests in v12/HEAD, add the relevant test case
there too, to prevent future regressions.

Chapman Flack (per private report)
src/backend/utils/adt/xml.c
src/test/regress/expected/xml.out
src/test/regress/expected/xml_1.out
src/test/regress/expected/xml_2.out
src/test/regress/sql/xml.sql