]> granicus.if.org Git - postgresql/commit
Don't access catalogs to validate GUCs when not connected to a DB.
authorAndres Freund <andres@anarazel.de>
Tue, 11 Jun 2019 06:20:48 +0000 (23:20 -0700)
committerAndres Freund <andres@anarazel.de>
Tue, 11 Jun 2019 06:34:50 +0000 (23:34 -0700)
commitfff2a7d7bd09db38e1bafc1303c29b10a9805dc0
tree724fe00c2aacf594793904fdec9d1cc1b211878d
parent92a88644d2b7208e98d9e913c3a574c5c2fe7b78
Don't access catalogs to validate GUCs when not connected to a DB.

Vignesh found this bug in the check function for
default_table_access_method's check hook, but that was just copied
from older GUCs. Investigation by Michael and me then found the bug in
further places.

When not connected to a database (e.g. in a walsender connection), we
cannot perform (most) GUC checks that need database access. Even when
only shared tables are needed, unless they're
nailed (c.f. RelationCacheInitializePhase2()), they cannot be accessed
without pg_class etc. being present.

Fix by extending the existing IsTransactionState() checks to also
check for MyDatabaseOid.

Reported-By: Vignesh C, Michael Paquier, Andres Freund
Author: Vignesh C, Andres Freund
Discussion: https://postgr.es/m/CALDaNm1KXK9gbZfY-p_peRFm_XrBh1OwQO1Kk6Gig0c0fVZ2uw%40mail.gmail.com
Backpatch: 9.4-
src/backend/access/table/tableamapi.c
src/backend/commands/tablespace.c
src/backend/utils/cache/ts_cache.c