]> granicus.if.org Git - postgresql/commit
Fix several memory leaks when rescanning SRFs. Arrange for an SRF's
authorNeil Conway <neilc@samurai.com>
Fri, 29 Feb 2008 02:49:43 +0000 (02:49 +0000)
committerNeil Conway <neilc@samurai.com>
Fri, 29 Feb 2008 02:49:43 +0000 (02:49 +0000)
commitfefe32d36f72efe20f8b4eb4e31987bcea6b08a6
treea31ba58587f11c6cb3eaa04106b6457d96b88a8c
parentbe99d75b4081590adf1f7860096c11d1059b134d
Fix several memory leaks when rescanning SRFs. Arrange for an SRF's
"multi_call_ctx" to be a distinct sub-context of the EState's per-query
context, and delete the multi_call_ctx as soon as the SRF finishes
execution. This avoids leaking SRF memory until the end of the current
query, which is particularly egregious when the SRF is scanned
multiple times. This change also fixes a leak of the fields of the
AttInMetadata struct in shutdown_MultiFuncCall().

Also fix a leak of the SRF result TupleDesc when rescanning a
FunctionScan node. The TupleDesc is allocated in the per-query context
for every call to ExecMakeTableFunctionResult(), so we should free it
after calling that function. Since the SRF might choose to return
a non-expendable TupleDesc, we only free the TupleDesc if it is
not being reference-counted.

Backpatch to 8.3 and 8.2 stable branches.
src/backend/executor/nodeFunctionscan.c
src/backend/utils/fmgr/funcapi.c