]> granicus.if.org Git - postgresql/commit
projects / postgresql / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 37e66e7) | patch
Avoid platform-dependent infinite loop in pg_dump.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Nov 2011 21:08:23 +0000 (16:08 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 10 Nov 2011 21:09:16 +0000 (16:09 -0500)
commitfebda37fda469317f15b0acadfbdedab3d7dc793
treeca3870684f316bd3674a857667c042faca5cc782tree | snapshot
parent37e66e75d8697de0fef74dad9cd9ae75845549b2commit | diff
Avoid platform-dependent infinite loop in pg_dump.

If malloc(0) returns NULL, the binary search in findSecLabels() will
probably go into an infinite loop when there are no security labels,
because NULL-1 is greater than NULL after wraparound.

(We've seen this pathology before ... I wonder whether there's a way to
detect the class of bugs automatically?)

Diagnosis and patch by Steve Singer, cosmetic adjustments by me
src/bin/pg_dump/pg_dump.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.