]> granicus.if.org Git - postgresql/commit
Fix failure-to-copy bug in commit 6f6b99d13.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 9 Sep 2017 00:45:31 +0000 (20:45 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 9 Sep 2017 00:45:31 +0000 (20:45 -0400)
commitfdf87ed451ef1ccb710f4e65dddbc6da17e92ba7
tree42570d39b3bacd3e89d6a2bfb8691d41b2efd632
parente56dd7cf5078d9651d715a72cd802a3aa346c63a
Fix failure-to-copy bug in commit 6f6b99d13.

The previous coding of get_qual_for_list() was careful to copy everything
it was using from the input data structure.  The new version missed
making a copy of pass-by-ref datum values that it's inserting into Consts.
This is not optional, however, as revealed by buildfarm failures on
machines running -DRELCACHE_FORCE_RELEASE: we're copying from a relcache
entry that could go away before the required lifespan of our output
expression.  I'm pretty sure -DCLOBBER_CACHE_ALWAYS machines won't like
this either, but none of them have reported in yet.
src/backend/catalog/partition.c