]> granicus.if.org Git - cgit/commit
ui-shared: don't print path crumbs without a repo
authorJohn Keeping <john@keeping.me.uk>
Sun, 19 Feb 2017 12:27:48 +0000 (12:27 +0000)
committerLukas Fleischer <lfleischer@lfos.de>
Thu, 10 Aug 2017 13:15:56 +0000 (15:15 +0200)
commitfdcd7dc8186e8d928876ae858b7d2d3a87d29453
tree6aaca987f01bd2bcd3d7f126db5e8ee7cf3f0d06
parent67e2b69ec96a117b98c9028013ce0258574efe80
ui-shared: don't print path crumbs without a repo

cgit_print_path_crumbs() can call repolink() which assumes that ctx.repo
is non-null.  Currently we don't have any commands that set want_vpath
without also setting want_repo so it shouldn't be possible to fail this
test, but the check in cgit.c is in the wrong order so it is possible to
specify a query string like "?p=log&path=foo/bar" to end up here without
a valid repository.

This was found by American fuzzy lop [0].

[0] http://lcamtuf.coredump.cx/afl/

Signed-off-by: John Keeping <john@keeping.me.uk>
ui-shared.c