]> granicus.if.org Git - postgresql/commit
Fix assorted compiler warnings seen in the buildfarm.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 May 2018 19:52:54 +0000 (15:52 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 May 2018 19:52:54 +0000 (15:52 -0400)
commitfbb2e9a030ee7a3fa20ce402e4b1da9809b4eb52
tree79bd48ec2dccce2957bf56d62019f24a86ab181c
parent447dbf7aa7909bca76048042d6734ee8f5249d0f
Fix assorted compiler warnings seen in the buildfarm.

Failure to use DatumGetFoo/FooGetDatum macros correctly, or at all,
causes some warnings about sign conversion.  This is just cosmetic
at the moment but in principle it's a type violation, so clean up
the instances I could find.

autoprewarm.c and sharedfileset.c contained code that unportably
assumed that pid_t is the same size as int.  We've variously dealt
with this by casting pid_t to int or to unsigned long for printing
purposes; I went with the latter.

Fix uninitialized-variable warning in RestoreGUCState.  This is
a live bug in some sense, but of no great significance given that
nobody is very likely to care what "line number" is associated with
a GUC that hasn't got a source file recorded.
contrib/hstore/hstore_io.c
contrib/jsonb_plpython/jsonb_plpython.c
contrib/pg_prewarm/autoprewarm.c
src/backend/storage/file/sharedfileset.c
src/backend/utils/adt/jsonb.c
src/backend/utils/adt/numeric.c
src/backend/utils/adt/pgstatfuncs.c
src/backend/utils/misc/guc.c