]> granicus.if.org Git - postgresql/commit
Clean up duplicate role and schema names in regression tests.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 15 Mar 2018 18:00:31 +0000 (14:00 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 15 Mar 2018 18:00:31 +0000 (14:00 -0400)
commitfb7db40ad26c3384f81d471442743076ade3f82a
treee764d90fe057b959aa5b433e58f217637a963730
parent3a4b891964a531aa7d242a48fcd9e41379863ead
Clean up duplicate role and schema names in regression tests.

Since these names are global, using the same ones in different regression
tests creates a hazard of test failures if any two such scripts run
concurrently.  Let's establish a policy of not doing that.  In the cases
where a conflict existed, I chose to rename both sides: in principle one
script or the other could've been left in possession of the common name,
but that seems to just invite more trouble of the same sort.

There are a number of places where scripts are using names that seem
unduly generic, but in the absence of actual conflicts I left them alone.

In addition, fix insert.sql's use of "someone_else" as a role name.
That's a flat out violation of longstanding project policy, so back-patch
that change to v10 where the usage appeared.  The rest of this is just
future-proofing, as no two of these scripts are actually run concurrently
in the existing parallel_schedule.

Conflicts of schema-qualified names also exist, but will be dealt with
separately.

Discussion: https://postgr.es/m/4627.1521070268@sss.pgh.pa.us
18 files changed:
src/test/regress/expected/alter_generic.out
src/test/regress/expected/alter_table.out
src/test/regress/expected/create_procedure.out
src/test/regress/expected/create_view.out
src/test/regress/expected/identity.out
src/test/regress/expected/insert.out
src/test/regress/expected/namespace.out
src/test/regress/expected/privileges.out
src/test/regress/expected/rolenames.out
src/test/regress/sql/alter_generic.sql
src/test/regress/sql/alter_table.sql
src/test/regress/sql/create_procedure.sql
src/test/regress/sql/create_view.sql
src/test/regress/sql/identity.sql
src/test/regress/sql/insert.sql
src/test/regress/sql/namespace.sql
src/test/regress/sql/privileges.sql
src/test/regress/sql/rolenames.sql