]> granicus.if.org Git - postgresql/commit
Fix O(N^2) behavior in pg_dump for large numbers of owned sequences.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 31 Mar 2012 18:42:23 +0000 (14:42 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 31 Mar 2012 18:42:23 +0000 (14:42 -0400)
commitfa76bb0168326b322a5dbb2cdffed51c79289cde
treed4bd3751958b2e5b9bb276aa7e6581a4f4b11102
parentdde1813dff577991a71bd3beedb333cd2ad2559f
Fix O(N^2) behavior in pg_dump for large numbers of owned sequences.

The loop that matched owned sequences to their owning tables required time
proportional to number of owned sequences times number of tables; although
this work was only expended in selective-dump situations, which is probably
why the issue wasn't recognized long since.  Refactor slightly so that we
can perform this work after the index array for findTableByOid has been
set up, reducing the time to O(M log N).

Per gripe from Mike Roest.  Since this is a longstanding performance bug,
backpatch to all supported versions.
src/bin/pg_dump/common.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dump.h