]> granicus.if.org Git - postgresql/commit
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 14 Jun 2010 20:49:46 +0000 (20:49 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 14 Jun 2010 20:49:46 +0000 (20:49 +0000)
commitfa66d0e2dac1f7b2d8106b9683cdb1f18153a857
treef0cc15709f37b2be20004352f653d04db9d01658
parent644c2778d6fc59818ffe627735fce265a905a943
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
lock the target relation just once per SQL function call.  The original coding
obtained and released lock several times per call.  Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently.  Also
centralize locking and permission-checking logic.

Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.
contrib/dblink/dblink.c