]> granicus.if.org Git - postgresql/commit
Fix line end mishandling in pg_upgrade on Windows.
authorAndrew Dunstan <andrew@dunslane.net>
Wed, 5 Sep 2012 21:49:30 +0000 (17:49 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Wed, 5 Sep 2012 21:49:30 +0000 (17:49 -0400)
commitf7b13e48375a5a8ea2a8b157622a9310512f4e27
tree06904e6fa67fbcbc3db4e51cb4d5f6c91a16ac1e
parenta05fa36ccf0dc7d6846564096d05b7c9bb86df45
Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.
contrib/pg_upgrade/dump.c