]> granicus.if.org Git - llvm/commit
[XRay] Update FDR log reader to be aware of buffer sizes per thread.
authorDean Michael Berris <dberris@google.com>
Wed, 29 Mar 2017 06:10:12 +0000 (06:10 +0000)
committerDean Michael Berris <dberris@google.com>
Wed, 29 Mar 2017 06:10:12 +0000 (06:10 +0000)
commitf5e37626b97d2797070c2b59dea1e2b1993cb32a
treef2464b74245c0859501879a3668b6e77d070f37c
parent8985450e52e924056c248786af72c1ea21a62f3a
[XRay] Update FDR log reader to be aware of buffer sizes per thread.

Summary:
It is problematic for this reader that it expects to read data from
several threads, but the header or message format does not define
framing. Since the buffers are reused, we can't rely on skipping
zeroed out data as a synchronization method either.

There is an argument that this is not version compatible with the format
the reader expected previously. I argue that since the writer wrote garbage
past the end of buffer record, there is no currently working reader to
compromise.

The corresponding writer change is posted to D31384.

Reviewers: dberris, pelikan

Reviewed By: dberris

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D31385

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@298983 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/XRay/XRayRecord.h
lib/XRay/Trace.cpp
test/tools/llvm-xray/X86/Inputs/fdr-log-version-1.xray