]> granicus.if.org Git - postgresql/commit
Don't record FDW user mappings as members of extensions.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 7 Aug 2018 20:32:50 +0000 (16:32 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 7 Aug 2018 20:33:17 +0000 (16:33 -0400)
commitf5973ac768df31f0661e4e0d56a3b435f80230f8
tree5a35c6af6bf6823502e4f9fc6d68e1739d251929
parent6be25d52cfbe8d43426721591513ae3725b7da6f
Don't record FDW user mappings as members of extensions.

CreateUserMapping has a recordDependencyOnCurrentExtension call that's
been there since extensions were introduced (very possibly my fault).
However, there's no support anywhere else for user mappings as members
of extensions, nor are they listed as a possible member object type in
the documentation.  Nor does it really seem like a good idea for user
mappings to belong to extensions when roles don't.  Hence, remove the
bogus call.

(As we saw in bug #15310, the lack of any pg_dump support for this case
ensures that any such membership record would silently disappear during
pg_upgrade.  So there's probably no need for us to do anything else
about cleaning up after this mistake.)

Discussion: https://postgr.es/m/27952.1533667213@sss.pgh.pa.us
src/backend/commands/foreigncmds.c