]> granicus.if.org Git - postgresql/commit
Fix order of arguments to SubTransSetParent().
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Apr 2017 17:10:57 +0000 (13:10 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Apr 2017 17:11:08 +0000 (13:11 -0400)
commitf5885488dacb62277c6452919e8961d27685675f
treea58edbd8c2843520c15a1bb61dfca6be9169df68
parent11927e575dd2afc8361e785c34db2141156702d6
Fix order of arguments to SubTransSetParent().

ProcessTwoPhaseBuffer (formerly StandbyRecoverPreparedTransactions)
mixed up the parent and child XIDs when calling SubTransSetParent to
record the transactions' relationship in pg_subtrans.

Remarkably, analysis by Simon Riggs suggests that this doesn't lead to
visible problems (at least, not in non-Assert builds).  That might
explain why we'd not noticed it before.  Nonetheless, it's surely wrong.

This code was born broken, so back-patch to all supported branches.

Discussion: https://postgr.es/m/20110.1492905318@sss.pgh.pa.us
src/backend/access/transam/twophase.c