]> granicus.if.org Git - postgresql/commit
Avoid unportable strftime() behavior in pg_dump/pg_dumpall.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 27 Oct 2014 00:59:21 +0000 (20:59 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 27 Oct 2014 00:59:21 +0000 (20:59 -0400)
commitf455fcfdb8ca3b67373223a4e15648c35e2592a9
tree0a303e28d2b17ed0633eea969f42cc91ebaa14be
parent9711fa06081da230e62fa52147c49ccf7b9ccbe2
Avoid unportable strftime() behavior in pg_dump/pg_dumpall.

Commit ad5d46a4494b0b480a3af246bb4227d9bdadca37 thought that we could
get around the known portability issues of strftime's %Z specifier by
using %z instead.  However, that idea seems to have been innocent of
any actual research, as it certainly missed the facts that
(1) %z is not portable to pre-C99 systems, and
(2) %z doesn't actually act differently from %Z on Windows anyway.

Per failures on buildfarm member hamerkop.

While at it, centralize the code defining what strftime format we
want to use in pg_dump; three copies of that string seems a bit much.
src/bin/pg_dump/dumputils.h
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_dumpall.c