]> granicus.if.org Git - clang/commit
[cmake] Reset variable before using it
authorShoaib Meenai <smeenai@fb.com>
Tue, 26 Mar 2019 22:16:53 +0000 (22:16 +0000)
committerShoaib Meenai <smeenai@fb.com>
Tue, 26 Mar 2019 22:16:53 +0000 (22:16 +0000)
commitf17219973cd3249977f260d834bc92ca9c16ee3b
treeffe7eec09683d31c9655cd1979813edd06a1b6f5
parent1eeae75f3fc8e59305cc7f738b11a0976cb4f0bc
[cmake] Reset variable before using it

A bunch of macros use the same variable name, and since CMake macros
don't get their own scope, the value persists across macro invocations,
and we can end up exporting targets which shouldn't be exported. Clear
the variable before each use to avoid this.

Converting these macros to functions would also help, since it would
avoid the variable leaking into its parent scope, and that's something I
plan to follow up with. It won't fully address the problem, however,
since functions still inherit variables from their parent scopes, so if
someone in the parent scope just happened to use the same variable name
we'd still have the same issue.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@357036 91177308-0d34-0410-b5e6-96231b3b80d8
cmake/modules/AddClang.cmake