]> granicus.if.org Git - postgresql/commit
Refactor planner's header files.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 29 Jan 2019 20:48:51 +0000 (15:48 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 29 Jan 2019 20:48:51 +0000 (15:48 -0500)
commitf09346a9c6218dd239fdf3a79a729716c0d305bd
treed33b3c1a0770578079e94991384923280991a252
parenta1b8c41e990ec0f083e9b684700a07640d5a356a
Refactor planner's header files.

Create a new header optimizer/optimizer.h, which exposes just the
planner functions that can be used "at arm's length", without need
to access Paths or the other planner-internal data structures defined
in nodes/relation.h.  This is intended to provide the whole planner
API seen by most of the rest of the system; although FDWs still need
to use additional stuff, and more thought is also needed about just
what selfuncs.c should rely on.

The main point of doing this now is to limit the amount of new
#include baggage that will be needed by "planner support functions",
which I expect to introduce later, and which will be in relevant
datatype modules rather than anywhere near the planner.

This commit just moves relevant declarations into optimizer.h from
other header files (a couple of which go away because everything
got moved), and adjusts #include lists to match.  There's further
cleanup that could be done if we want to decide that some stuff
being exposed by optimizer.h doesn't belong in the planner at all,
but I'll leave that for another day.

Discussion: https://postgr.es/m/11460.1548706639@sss.pgh.pa.us
91 files changed:
contrib/bloom/blcost.c
contrib/file_fdw/file_fdw.c
contrib/postgres_fdw/deparse.c
contrib/postgres_fdw/postgres_fdw.c
contrib/tsm_system_rows/tsm_system_rows.c
contrib/tsm_system_time/tsm_system_time.c
src/backend/access/gist/gistbuild.c
src/backend/access/spgist/spgutils.c
src/backend/access/tablesample/bernoulli.c
src/backend/access/tablesample/system.c
src/backend/access/transam/parallel.c
src/backend/catalog/heap.c
src/backend/catalog/index.c
src/backend/catalog/partition.c
src/backend/commands/cluster.c
src/backend/commands/copy.c
src/backend/commands/explain.c
src/backend/commands/functioncmds.c
src/backend/commands/indexcmds.c
src/backend/commands/tablecmds.c
src/backend/commands/trigger.c
src/backend/commands/typecmds.c
src/backend/executor/execExpr.c
src/backend/executor/execMain.c
src/backend/executor/execParallel.c
src/backend/executor/nodeAgg.c
src/backend/executor/nodeGather.c
src/backend/executor/nodeGatherMerge.c
src/backend/executor/nodeIndexscan.c
src/backend/executor/nodeWindowAgg.c
src/backend/jit/llvm/llvmjit_expr.c
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/path/clausesel.c
src/backend/optimizer/path/costsize.c
src/backend/optimizer/path/equivclass.c
src/backend/optimizer/path/indxpath.c
src/backend/optimizer/path/pathkeys.c
src/backend/optimizer/path/tidpath.c
src/backend/optimizer/plan/analyzejoins.c
src/backend/optimizer/plan/createplan.c
src/backend/optimizer/plan/initsplan.c
src/backend/optimizer/plan/planagg.c
src/backend/optimizer/plan/planmain.c
src/backend/optimizer/plan/planner.c
src/backend/optimizer/plan/setrefs.c
src/backend/optimizer/plan/subselect.c
src/backend/optimizer/prep/prepjointree.c
src/backend/optimizer/prep/prepqual.c
src/backend/optimizer/prep/preptlist.c
src/backend/optimizer/util/clauses.c
src/backend/optimizer/util/orclauses.c
src/backend/optimizer/util/pathnode.c
src/backend/optimizer/util/placeholder.c
src/backend/optimizer/util/plancat.c
src/backend/optimizer/util/predtest.c
src/backend/optimizer/util/restrictinfo.c
src/backend/optimizer/util/tlist.c
src/backend/optimizer/util/var.c
src/backend/parser/analyze.c
src/backend/parser/parse_agg.c
src/backend/parser/parse_clause.c
src/backend/parser/parse_expr.c
src/backend/parser/parse_utilcmd.c
src/backend/partitioning/partbounds.c
src/backend/partitioning/partprune.c
src/backend/replication/logical/worker.c
src/backend/rewrite/rewriteManip.c
src/backend/statistics/dependencies.c
src/backend/tcop/postgres.c
src/backend/utils/adt/array_selfuncs.c
src/backend/utils/adt/orderedsetaggs.c
src/backend/utils/adt/ruleutils.c
src/backend/utils/adt/selfuncs.c
src/backend/utils/cache/partcache.c
src/backend/utils/cache/plancache.c
src/backend/utils/cache/relcache.c
src/backend/utils/cache/spccache.c
src/backend/utils/cache/typcache.c
src/backend/utils/misc/guc.c
src/include/nodes/relation.h
src/include/optimizer/clauses.h
src/include/optimizer/cost.h
src/include/optimizer/optimizer.h [new file with mode: 0644]
src/include/optimizer/planmain.h
src/include/optimizer/planner.h
src/include/optimizer/predtest.h [deleted file]
src/include/optimizer/prep.h
src/include/optimizer/tlist.h
src/include/optimizer/var.h [deleted file]
src/pl/plpgsql/src/pl_exec.c
src/test/modules/test_predtest/test_predtest.c