]> granicus.if.org Git - postgresql/commit
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:49:54 +0000 (15:49 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:50:48 +0000 (15:50 -0500)
commiteff027c43288d15307676b1bd4736ab11f34c407
treeb96c49ff6c63a175c400e90eda7b92551e3f7c53
parentfe8f15d5d2f42ad1ce6a0114c12fd3da0f14dd4a
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.

Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.)  When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk.  Better to throw a suitable error when the
DROP is attempted.

Also add a similar check in DROP INDEX.

Back-patch to all supported branches.
src/backend/catalog/heap.c
src/backend/catalog/index.c
src/interfaces/ecpg/test/expected/sql-fetch.stderr