]> granicus.if.org Git - postgresql/commit
Repair unsafe/unportable snprintf usage in pg_restore.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 10 Feb 2019 00:45:38 +0000 (19:45 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 10 Feb 2019 00:45:38 +0000 (19:45 -0500)
commitef9bf359369b4dfaceb859941c3898b5ce1decf6
tree6d151b2d3ed43a389bd92d15b738144b677d63be
parent027b5a300a9e9b407f465f0264cb88305eb0539d
Repair unsafe/unportable snprintf usage in pg_restore.

warn_or_exit_horribly() was blithely passing a potentially-NULL
string pointer to a %s format specifier.  That works (at least
to the extent of not crashing) on some platforms, but not all,
and since we switched to our own snprintf.c it doesn't work
for us anywhere.

Of the three string fields being handled this way here, I think
that only "owner" is supposed to be nullable ... but considering
that this is error-reporting code, it has very little business
assuming anything, so put in defenses for all three.

Per a crash observed on buildfarm member crake and then
reproduced here.  Because of the portability aspect,
back-patch to all supported versions.
src/bin/pg_dump/pg_backup_archiver.c