]> granicus.if.org Git - zfs/commit
Fix ZVOL BLKFLSBUF ioctl
authorBrian Behlendorf <behlendorf1@llnl.gov>
Fri, 10 Mar 2017 01:43:36 +0000 (17:43 -0800)
committerGitHub <noreply@github.com>
Fri, 10 Mar 2017 01:43:36 +0000 (17:43 -0800)
commitef1bdf363c021525c1db9630647dea73498c6bfd
treee8a0f6cb68803d158f31c94638747a18a102c102
parent589bb918ef39058b1f06da72092e895835a7aaff
Fix ZVOL BLKFLSBUF ioctl

The BLKFLSBUF ioctl is expected to do two things:

  - flush dirty pages to stable storage, and
  - invalidate clean pages

Unfortunately, the existing implementation of BLKFLSBUF in
zvol_ioctl() only flushes pages which are part of the current
TXG to disk.  There may be additional dirty pages in the
page cache which haven't yet been submitted to the DMU and
therefore aren't part of any TXG.

Furthermore because zvol_ioctl() returns 0 the generic
blkdev_flushbuf() does not invalidate the page cache.

Resolve the issue by moving bdev_flush() in to zvol_ioctl()
and explicitly waiting for a full TXG sync.  Then invalidate
the page cache.  The associated ARC buffers need not be
evicted since they cannot be bypassed using O_DIRECT.

Reviewed-by: Chunwei Chen <david.chen@osnexus.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #5871
Closes #5879
module/zfs/zvol.c