]> granicus.if.org Git - postgresql/commit
Back off chattiness in RemovePgTempFiles().
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Jan 2018 01:40:40 +0000 (20:40 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 8 Jan 2018 01:40:40 +0000 (20:40 -0500)
commiteeb3c2df429c943b2f8d028d110b55ac0a53dc75
treedcc9ad2922c8d3e01477f035f65ca5dd233a2a3f
parent6271fceb8a4f07dafe9d67dcf7e849b319bb2647
Back off chattiness in RemovePgTempFiles().

In commit 561885db0, as part of normalizing RemovePgTempFiles's error
handling, I removed its behavior of silently ignoring ENOENT failures
during directory opens.  Thomas Munro points out that this is a bad idea at
the top level, because we don't create pgsql_tmp directories until needed.
Thus this coding could produce LOG messages in perfectly normal situations,
which isn't what I intended.  Restore the suppression of ENOENT logging,
but only at top level --- it would still be unexpected for a nested temp
directory to disappear between seeing it in the parent directory and
opening it.

Discussion: https://postgr.es/m/CAEepm=2y06SehAkTnd5sU_eVqdv5P-=Srt1y5vYNQk6yVDVaPw@mail.gmail.com
src/backend/storage/file/fd.c