]> granicus.if.org Git - postgresql/commit
Avoid having vacuum set reltuples to 0 on non-empty relations in the
authorAndrew Gierth <rhodiumtoad@postgresql.org>
Thu, 16 Mar 2017 22:32:31 +0000 (22:32 +0000)
committerAndrew Gierth <rhodiumtoad@postgresql.org>
Thu, 16 Mar 2017 22:33:59 +0000 (22:33 +0000)
commitee78ad5bc0d2b905fdfcee997c76e98292f65fbb
treecded76b37f76a271f01f067041dc593234f05ff2
parent087e696f066d31cb2f1269a1296a13dfe0bf7a11
Avoid having vacuum set reltuples to 0 on non-empty relations in the
presence of page pins, which leads to serious estimation errors in the
planner.  This particularly affects small heavily-accessed tables,
especially where locking (e.g. from FK constraints) forces frequent
vacuums for mxid cleanup.

Fix by keeping separate track of pages whose live tuples were actually
counted vs. pages that were only scanned for freezing purposes.  Thus,
reltuples can only be set to 0 if all pages of the relation were
actually counted.

Backpatch to all supported versions.

Per bug #14057 from Nicolas Baccelli, analyzed by me.

Discussion: https://postgr.es/m/20160331103739.8956.94469@wrigleys.postgresql.org
src/backend/commands/vacuumlazy.c