]> granicus.if.org Git - postgresql/commit
Attach FPI to the first record after full_page_writes is turned on.
authorAmit Kapila <akapila@postgresql.org>
Thu, 13 Sep 2018 10:31:57 +0000 (16:01 +0530)
committerAmit Kapila <akapila@postgresql.org>
Thu, 13 Sep 2018 10:31:57 +0000 (16:01 +0530)
commitede7d8192ca3d1f731d34fb82fdcfc3308b4355f
treef484b5ccecde56b9ed00314043a09b61fc7c41ee
parentaed0150eda2cb8b56b00b1a5cfcb452f0fa8235b
Attach FPI to the first record after full_page_writes is turned on.

XLogInsert fails to attach a required FPI to the first record after
full_page_writes is turned on by the last checkpoint.  This bug got
introduced in 9.5 due to code rearrangement in commits 2c03216d83 and
2076db2aea.  Fix it by ensuring that XLogInsertRecord performs a
recomputation when the given record is generated with FPW as off but
found that the flag has been turned on while actually inserting the
record.

Reported-by: Kyotaro Horiguchi
Author: Kyotaro Horiguchi
Reviewed-by: Amit Kapila
Backpatch-through: 9.5 where this problem was introduced
Discussion: https://postgr.es/m/20180420.151043.74298611.horiguchi.kyotaro@lab.ntt.co.jp
src/backend/access/transam/xlog.c