]> granicus.if.org Git - postgresql/commit
Forbid invalid combination of options in pg_basebackup.
authorFujii Masao <fujii@postgresql.org>
Wed, 21 Dec 2016 11:27:37 +0000 (20:27 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 21 Dec 2016 11:27:37 +0000 (20:27 +0900)
commitecbdc4c555f43b1ac284c734752b00c2ea6f277b
tree55f85dc5084489c96fdc489b0bcf5cbfe3a6e572
parentc080b223a7a3991524a5287416a0ad756c15a098
Forbid invalid combination of options in pg_basebackup.

Commit 56c7d8d4552180fd66fe48423bb2a9bb767c2d87 allowed pg_basebackup
to stream WAL in tar mode. But there is the restriction that WAL
streaming in tar mode works only when the value - (dash) is not
specified as output directory. This means that the combination of
three options "-D -", "-F t" and "-X stream" is invalid. However,
previously, even when those options were specified at the same time,
pg_basebackup background process unexpectedly started streaming WAL.
And then it exited with an error.

This commit changes pg_basebackup so that it errors out on such
invalid combination of options at the beginning.

Reviewed by Magnus Hagander, and patch by me.
src/bin/pg_basebackup/pg_basebackup.c