]> granicus.if.org Git - postgresql/commit
Fix line end mishandling in pg_upgrade on Windows.
authorAndrew Dunstan <andrew@dunslane.net>
Wed, 5 Sep 2012 21:41:43 +0000 (17:41 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Wed, 5 Sep 2012 21:41:43 +0000 (17:41 -0400)
commitea0b414a0d9caaad1b7f39acd57708895c4dd0f3
treede13bb858415fa609eccd0de3547b0f8375fbf91
parent28ab4a5aabeec1db7e9d6fd14c26cc92ccb670a2
Fix line end mishandling in pg_upgrade on Windows.

pg_upgrade opened the output from pg_dumpall in text mode and
wrote the split files in text mode. This caused unwanted eating
of intended carriage returns on input and production of spurious
carriage returns on output. To avoid this, open all these files
in binary mode. On non-Windows platforms, this change has no
effect.

Backpatch to 9.0. On 9.0 and 9.1, we also switch from redirecting
pg_dumpall's output to using pg_dumpall's -f switch, for the same
reason.
contrib/pg_upgrade/dump.c