]> granicus.if.org Git - postgresql/commit
Parse more strictly integer parameters from connection strings in libpq
authorMichael Paquier <michael@paquier.xyz>
Tue, 11 Sep 2018 21:46:01 +0000 (06:46 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 11 Sep 2018 21:46:01 +0000 (06:46 +0900)
commite7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
tree284ebcfa72befbbab4c67950c85ce93902d7842e
parent0d45cd96fd0f3387d1bcf7e6f873c73c4f251df8
Parse more strictly integer parameters from connection strings in libpq

The following parameters have been parsed in lossy ways when specified
in a connection string processed by libpq:
- connect_timeout
- keepalives
- keepalives_count
- keepalives_idle
- keepalives_interval
- port

Overflowing values or the presence of incorrect characters were not
properly checked, leading to libpq trying to use such values and fail
with unhelpful error messages.  This commit hardens the parsing of those
parameters so as it is possible to find easily incorrect values.

Author: Fabien Coelho
Reviewed-by: Peter Eisentraut, Michael Paquier
Discussion: https://postgr.es/m/alpine.DEB.2.21.1808171206180.20841@lancre
src/interfaces/libpq/fe-connect.c