Fix handling of NULL distances in KNN-GiST
authorAlexander Korotkov <akorotkov@postgresql.org>
Sun, 8 Sep 2019 18:13:40 +0000 (21:13 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sun, 8 Sep 2019 18:17:37 +0000 (21:17 +0300)
commite6af7b367cf46fc385307efcef5a1fece0e5fef3
treed9aee5bd1ad49e2492e240788f7688c5cfee7935
parentbc67f4189a7a3381db76dbfeafca463187bfe87a
Fix handling of NULL distances in KNN-GiST

In order to implement NULL LAST semantic GiST previously assumed distance to
the NULL value to be Inf.  However, our distance functions can return Inf and
NaN for non-null values.  In such cases, NULL LAST semantic appears to be
broken.  This commit fixes that by introducing separate array of null flags for
distances.

Backpatch to all supported versions.

Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 9.4
src/backend/access/gist/gistget.c
src/backend/access/gist/gistscan.c
src/backend/access/index/indexam.c
src/backend/access/spgist/spgscan.c
src/include/access/genam.h
src/include/access/gist_private.h
src/test/regress/expected/create_index.out