]> granicus.if.org Git - postgresql/commit
Fix full-page writes of internal GIN pages.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 3 Dec 2013 20:13:16 +0000 (22:13 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 3 Dec 2013 20:34:43 +0000 (22:34 +0200)
commite6acb956a0505572b470daf27c145e930e689b23
tree6fb4998211d44eea8d2eb2e9f18977e7ae915b0d
parentf67b8aeab3a543d156787de7311d4a98f228ab9f
Fix full-page writes of internal GIN pages.

Insertion to a non-leaf GIN page didn't make a full-page image of the page,
which is wrong. The code used to do it correctly, but was changed (commit
853d1c3103fa961ae6219f0281885b345593d101) because the redo-routine didn't
track incomplete splits correctly when the page was restored from a full
page image. Of course, that was not right way to fix it, the redo routine
should've been fixed instead. The redo-routine was surreptitiously fixed
in 2010 (commit 4016bdef8aded77b4903c457050622a5a1815c16), so all we need
to do now is revert the code that creates the record to its original form.

This doesn't change the format of the WAL record.

Backpatch to all supported versions.
src/backend/access/gin/gindatapage.c
src/backend/access/gin/ginentrypage.c