]> granicus.if.org Git - php/commit
Fixed bug #66242 (don't assume char is signed)
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Sat, 20 Sep 2014 23:32:31 +0000 (16:32 -0700)
committerArd Biesheuvel <ard.biesheuvel@linaro.org>
Sat, 20 Sep 2014 23:39:48 +0000 (16:39 -0700)
commite64da8c20df3ec28bd2417924b207b870e9ab99f
tree2086ff13b56f9599297eefd969852505922a2555
parent00525b824af4265e7fc74d3655a04da9c4c667f7
Fixed bug #66242 (don't assume char is signed)

This fixes a bug in libmagic where a cast to 'char' is assumed to result
in sign extension to occur. However, unqualified 'char' is unsigned on
architectures such as ARM, so the cast needs to be to 'signed char'
explicitly.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
ext/fileinfo/libmagic/apprentice.c