]> granicus.if.org Git - postgresql/commit
Code review for magic-block patch. Remove separate header file pgmagic.h,
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 30 May 2006 21:21:30 +0000 (21:21 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 30 May 2006 21:21:30 +0000 (21:21 +0000)
commite60cb3a35c88d33dbfc53afb91f5bfff4209dad0
tree2a412f096d66722388b2b4b9d177ea37ab413866
parenta18ebc5541c20bf6aca70532bbf1a0531d1b2659
Code review for magic-block patch.  Remove separate header file pgmagic.h,
as this seems only likely to create headaches for module developers.  Put
the macro in the pre-existing fmgr.h file instead.  Avoid being too cute
about how many fields we can cram into a word, and avoid trying to fetch
from a library we've already unlinked.
Along the way, it occurred to me that the magic block really ought to be
'const' so it can be stored in the program text area.  Do the same for
the existing data blocks for PG_FUNCTION_INFO_V1 functions.
doc/src/sgml/xfunc.sgml
src/backend/utils/fmgr/dfmgr.c
src/backend/utils/fmgr/fmgr.c
src/include/fmgr.h
src/include/pgmagic.h [deleted file]
src/test/regress/regress.c