]> granicus.if.org Git - postgresql/commit
Improve coding of gistchoose and gistRelocateBuildBuffersOnSplit.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 31 Aug 2012 02:52:43 +0000 (22:52 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 31 Aug 2012 02:53:17 +0000 (22:53 -0400)
commite5db11c5582b469c04a11f217a0f32c827da5dd7
treeefc81df37bab68999a6c6a3883c67d6b8e173fdb
parent5fcb58baca7a78e688b84275958c450670ba62a8
Improve coding of gistchoose and gistRelocateBuildBuffersOnSplit.

This is mostly cosmetic, but it does eliminate a speculative portability
issue.  The previous coding ignored the fact that sum_grow could easily
overflow (in fact, it could be summing multiple IEEE float infinities).
On a platform where that didn't guarantee to produce a positive result,
the code would misbehave.  In any case, it was less than readable.
src/backend/access/gist/gistbuildbuffers.c
src/backend/access/gist/gistutil.c