]> granicus.if.org Git - postgresql/commit
Fix some minor spec-compliance issues in jsonpath lexer.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 20 Sep 2019 18:22:58 +0000 (14:22 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 20 Sep 2019 18:22:58 +0000 (14:22 -0400)
commite56cad84d542a8cc2056390a9c651118cfa6c89c
treec4d6b3ea69ae574e3880507f77037c474309755b
parent96b6c82c9dd4a6a91c7e54bf42d36da111959ec6
Fix some minor spec-compliance issues in jsonpath lexer.

Although the SQL/JSON tech report makes reference to ECMAScript which
allows both single- and double-quoted strings, all the rest of the
report speaks only of double-quoted string literals in jsonpaths.
That's more compatible with JSON itself; moreover single-quoted strings
are hard to use inside a jsonpath that is itself a single-quoted SQL
literal.  So guess that the intent is to allow only double-quoted
literals, and remove lexer support for single-quoted literals.
It'll be less painful to add this again later if we're wrong, than to
remove a shipped feature.

Also, adjust the lexer so that unrecognized backslash sequences are
treated as just meaning the escaped character, not as errors.  This
change has much better support in the standards, as JSON, JavaScript
and ECMAScript all make it plain that that's what's supposed to
happen.

Back-patch to v12.

Discussion: https://postgr.es/m/CAPpHfdvDci4iqNF9fhRkTqhe-5_8HmzeLt56drH%2B_Rv2rNRqfg@mail.gmail.com
src/backend/utils/adt/jsonpath_scan.l
src/test/regress/expected/jsonpath.out
src/test/regress/expected/jsonpath_encoding.out
src/test/regress/expected/jsonpath_encoding_1.out
src/test/regress/sql/jsonpath.sql
src/test/regress/sql/jsonpath_encoding.sql