]> granicus.if.org Git - postgresql/commit
Avoid deadlocks during insertion into SP-GiST indexes.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 14 Jun 2013 18:26:43 +0000 (14:26 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 14 Jun 2013 18:26:43 +0000 (14:26 -0400)
commite472b921406407794bab911c64655b8b82375196
tree584905c337bcc4648fcf193efacc21f8f9c12e52
parentc62866eeafd52822ec61a0d2db9428c05e97d3cc
Avoid deadlocks during insertion into SP-GiST indexes.

SP-GiST's original scheme for avoiding deadlocks during concurrent index
insertions doesn't work, as per report from Hailong Li, and there isn't any
evident way to make it work completely.  We could possibly lock individual
inner tuples instead of their whole pages, but preliminary experimentation
suggests that the performance penalty would be huge.  Instead, if we fail
to get a buffer lock while descending the tree, just restart the tree
descent altogether.  We keep the old tuple positioning rules, though, in
hopes of reducing the number of cases where this can happen.

Teodor Sigaev, somewhat edited by Tom Lane
src/backend/access/spgist/README
src/backend/access/spgist/spgdoinsert.c
src/backend/access/spgist/spginsert.c
src/include/access/spgist_private.h