]> granicus.if.org Git - postgresql/commit
Further improvements to c8f621c43.
authorAndres Freund <andres@anarazel.de>
Mon, 7 Mar 2016 22:24:58 +0000 (14:24 -0800)
committerAndres Freund <andres@anarazel.de>
Mon, 7 Mar 2016 22:24:58 +0000 (14:24 -0800)
commite3e84fd35838a43feef94ea78534713d745e9a08
treeea5e0de2b81e6018d20d12d3f7911fd04cbb8ddc
parent89f8372cb3a223cace21d4037336bfb37e8dbf3c
Further improvements to c8f621c43.

Coverity and inspection for the issue addressed in fd45d16f found some
questionable code.

Specifically coverity noticed that the wrong length was added in
ReorderBufferSerializeChange() - without immediate negative consequences
as the variable isn't used afterwards.  During code-review and testing I
noticed that a bit of space was wasted when allocating tuple bufs in
several places.  Thirdly, the debug memset()s in
ReorderBufferGetTupleBuf() reduce the error checking valgrind can do.

Backpatch: 9.4, like c8f621c43.
src/backend/replication/logical/decode.c
src/backend/replication/logical/reorderbuffer.c