]> granicus.if.org Git - postgresql/commit
Wait between tablesync worker restarts
authorPeter Eisentraut <peter_e@gmx.net>
Thu, 27 Apr 2017 18:57:26 +0000 (14:57 -0400)
committerPeter Eisentraut <peter_e@gmx.net>
Fri, 28 Apr 2017 17:47:46 +0000 (13:47 -0400)
commite3cf708016ca6045dc1cd5a0768cfecf17caf3d1
tree17a1354e2fef5dea53672215fa45459ea7c839a0
parentd981074c24d2f1e4f44bc6d80e967e523ce64f50
Wait between tablesync worker restarts

Before restarting a tablesync worker for the same relation, wait
wal_retrieve_retry_interval (currently 5s by default).  This avoids
restarting failing workers in a tight loop.

We keep the last start times in a hash table last_start_times that is
separate from the table_states list, because that list is cleared out on
syscache invalidation, which happens whenever a table finishes syncing.
The hash table is kept until all tables have finished syncing.

A future project might be to unify these two and keep everything in one
data structure, but for now this is a less invasive change to accomplish
the original purpose.

For the test suite, set wal_retrieve_retry_interval to its minimum
value, to not increase the test suite run time.

Reviewed-by: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Reported-by: Masahiko Sawada <sawada.mshk@gmail.com>
src/backend/replication/logical/tablesync.c
src/test/subscription/t/004_sync.pl