]> granicus.if.org Git - postgresql/commit
Attached is my attempt to clean up the horrors of the ExecSQL() method in
authorBruce Momjian <bruce@momjian.us>
Thu, 6 Sep 2001 03:13:34 +0000 (03:13 +0000)
committerBruce Momjian <bruce@momjian.us>
Thu, 6 Sep 2001 03:13:34 +0000 (03:13 +0000)
commite30b283f30c39648abc17e14b709ad93f53aac95
treea3258bb5d7c2dfd999b58779aac76d44e7437f25
parentd99794e613a74fd4810f51db4f1af405fd3b5507
Attached is my attempt to clean up the horrors of the ExecSQL() method in
the JDBC driver.

I've done this by extracting it into a new method object called
QueryExecutor (should go into org/postgresql/core/) and then taking it
apart into different methods in that class.

A short summary:

* Extracted ExecSQL() from Connection into a method object called
  QueryExecutor.

* Moved ReceiveFields() from Connection to QueryExecutor.

* Extracted parts of the original ExecSQL() method body into smaller
  methods on QueryExecutor.

* Bug fix: The instance variable "pid" in Connection was used in two
  places with different meaning. Both were probably in dead code, but it's
  fixed anyway.

Anders Bengtsson
src/interfaces/jdbc/org/postgresql/Connection.java
src/interfaces/jdbc/org/postgresql/jdbc1/Connection.java
src/interfaces/jdbc/org/postgresql/jdbc2/Connection.java