]> granicus.if.org Git - postgresql/commit
Fix SortTocFromFile() to cope with lines that are too long for its buffer.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Apr 2011 15:40:28 +0000 (11:40 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 7 Apr 2011 15:40:28 +0000 (11:40 -0400)
commite2c946018fe27e5b21d8e2cd00d05f33b19709a4
treeb16b917d061047c9b59a995bd0f4331028876d50
parent672def62259354f28000e8cfb97b6668192369c2
Fix SortTocFromFile() to cope with lines that are too long for its buffer.

The original coding supposed that a dump TOC file could never contain lines
longer than 1K.  The folly of that was exposed by a recent report from
Per-Olov Esgard.  We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.

Back-patch to all supported branches, since it's always been like this.
src/bin/pg_dump/pg_backup_archiver.c