]> granicus.if.org Git - clang/commit
[analyzer] Consolidate constant evaluation logic in SValBuilder.
authorJordan Rose <jordan_rose@apple.com>
Wed, 1 May 2013 23:10:44 +0000 (23:10 +0000)
committerJordan Rose <jordan_rose@apple.com>
Wed, 1 May 2013 23:10:44 +0000 (23:10 +0000)
commite2b1246a24e8babf2f58c93713fba16b8edb8e2d
treed8766203cedcf2cf15f3cdd862b207ebd89d374e
parent776d3bb65c90278b9c65544b235d2ac40aea1d6e
[analyzer] Consolidate constant evaluation logic in SValBuilder.

Previously, this was scattered across Environment (literal expressions),
ExprEngine (default arguments), and RegionStore (global constants). The
former special-cased several kinds of simple constant expressions, while
the latter two deferred to the AST's constant evaluator.

Now, these are all unified as SValBuilder::getConstantVal(). To keep
Environment fast, the special cases for simple constant expressions have
been left in, but the main benefits are that (a) unusual constants like
ObjCStringLiterals now work as default arguments and global constant
initializers, and (b) we're not duplicating code between ExprEngine and
RegionStore.

This actually caught a bug in our test suite, which is awesome: we stop
tracking allocated memory if it's passed as an argument along with some
kind of callback, but not if the callback is 0. We were testing this in
a case where the callback parameter had a default value, but that value
was 0. After this change, the analyzer now (correctly) flags that as a
leak!

<rdar://problem/13773117>

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@180894 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h
lib/StaticAnalyzer/Core/Environment.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/StaticAnalyzer/Core/RegionStore.cpp
lib/StaticAnalyzer/Core/SValBuilder.cpp
test/Analysis/malloc.cpp
test/Analysis/objc-string.mm [new file with mode: 0644]