]> granicus.if.org Git - postgresql/commit
Fix bogus Name assignment in CreateStatistics
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 6 Mar 2018 16:17:13 +0000 (13:17 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 6 Mar 2018 16:21:04 +0000 (13:21 -0300)
commite20dd6a13d870f5c98a163031b38ba23753e628c
treee14664f77ea7caa6998084936a01194e38bb3f4e
parent911e6236bab5b1c2240c087e5e8a110acdb724ba
Fix bogus Name assignment in CreateStatistics

Apparently, it doesn't work to use a plain cstring as a Name datum: you
may end up having random bytes because of failing to zero the bytes
after the terminating \0, as indicated by valgrind.  I introduced this
bug in 5564c1181548, so backpatch this fix to REL_10_STABLE, like that
commit.

While at it, fix a slightly misleading comment, pointed out by David
Rowley.
src/backend/commands/statscmds.c
src/backend/parser/parse_utilcmd.c