Fix pg_dumpall so that when --clean is specified, it drops roles and
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 11 Apr 2009 20:23:05 +0000 (20:23 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 11 Apr 2009 20:23:05 +0000 (20:23 +0000)
commite1e17e2a0a31815f8d2b33a29e7c0cea626ca8fd
treede100c9f23461bef9bbb351fe442a8eb4fc4eeb6
parent088ac581d4b8890ef80c6f22ac3da388d981e70c
Fix pg_dumpall so that when --clean is specified, it drops roles and
tablespaces in an order that has some chance of working.
Per a complaint from Kevin Bailey.

This is a pre-existing bug, but given the lack of prior complaints I'm
not sure it's worth back-patching.  In most cases failure of the DROP
commands wouldn't be that important anyway.

In passing, fix syntax errors in dumpCreateDB()'s queries for old servers;
these were apparently introduced in recent binary_upgrade patch.
src/bin/pg_dump/pg_dumpall.c