]> granicus.if.org Git - postgresql/commit
Empty search_path in Autovacuum and non-psql/pgbench clients.
authorNoah Misch <noah@leadboat.com>
Mon, 26 Feb 2018 15:39:44 +0000 (07:39 -0800)
committerNoah Misch <noah@leadboat.com>
Mon, 26 Feb 2018 15:39:48 +0000 (07:39 -0800)
commite170b8c8c62064a16837c9838ef7a168fa9c9506
tree0675d27b686528857c71c4b1ef866ce3f5c78348
parent815172ba8068dbca9b585ed4aa975db00bef01d8
Empty search_path in Autovacuum and non-psql/pgbench clients.

This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects.  Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser.  This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".

This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump().  If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear.  Users may fix such errors
by schema-qualifying affected names.  After upgrading, consider watching
server logs for these errors.

The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint.  That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.

Back-patch to 9.3 (all supported versions).

Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.

Security: CVE-2018-1058
26 files changed:
contrib/oid2name/oid2name.c
contrib/vacuumlo/vacuumlo.c
src/backend/postmaster/autovacuum.c
src/bin/pg_basebackup/streamutil.c
src/bin/pg_dump/pg_backup_db.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dumpall.c
src/bin/pg_rewind/libpq_fetch.c
src/bin/pg_upgrade/server.c
src/bin/scripts/clusterdb.c
src/bin/scripts/common.c
src/bin/scripts/common.h
src/bin/scripts/createdb.c
src/bin/scripts/createlang.c
src/bin/scripts/createuser.c
src/bin/scripts/dropdb.c
src/bin/scripts/droplang.c
src/bin/scripts/dropuser.c
src/bin/scripts/reindexdb.c
src/bin/scripts/t/010_clusterdb.pl
src/bin/scripts/t/090_reindexdb.pl
src/bin/scripts/t/100_vacuumdb.pl
src/bin/scripts/vacuumdb.c
src/fe_utils/string_utils.c
src/include/fe_utils/connect.h [new file with mode: 0644]
src/tools/findoidjoins/findoidjoins.c