]> granicus.if.org Git - llvm/commit
Allow DataLayout to specify addrspace for allocas.
authorMatt Arsenault <Matthew.Arsenault@amd.com>
Mon, 10 Apr 2017 22:27:50 +0000 (22:27 +0000)
committerMatt Arsenault <Matthew.Arsenault@amd.com>
Mon, 10 Apr 2017 22:27:50 +0000 (22:27 +0000)
commite0b3c335a27ae50c4f339ffb81c18662bc983e52
treed2646d5d289af3569a5ef32becf88785dadba302
parent400ee3160b61e7c6dc2d382c1648ac84162a84d6
Allow DataLayout to specify addrspace for allocas.

LLVM makes several assumptions about address space 0. However,
alloca is presently constrained to always return this address space.
There's no real way to avoid using alloca, so without this
there is no way to opt out of these assumptions.

The problematic assumptions include:
- That the pointer size used for the stack is the same size as
  the code size pointer, which is also the maximum sized pointer.

- That 0 is an invalid, non-dereferencable pointer value.

These are problems for AMDGPU because alloca is used to
implement the private address space, which uses a 32-bit
index as the pointer value. Other pointers are 64-bit
and behave more like LLVM's notion of generic address
space. By changing the address space used for allocas,
we can change our generic pointer type to be LLVM's generic
pointer type which does have similar properties.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299888 91177308-0d34-0410-b5e6-96231b3b80d8
34 files changed:
docs/LangRef.rst
include/llvm/IR/DataLayout.h
include/llvm/IR/IRBuilder.h
include/llvm/IR/Instructions.h
lib/AsmParser/LLParser.cpp
lib/AsmParser/LLParser.h
lib/Bitcode/Reader/BitcodeReader.cpp
lib/CodeGen/SjLjEHPrepare.cpp
lib/CodeGen/WinEHPrepare.cpp
lib/IR/AsmWriter.cpp
lib/IR/DataLayout.cpp
lib/IR/Instructions.cpp
lib/IR/Verifier.cpp
lib/Target/NVPTX/NVPTXLowerArgs.cpp
lib/Transforms/Coroutines/CoroElide.cpp
lib/Transforms/IPO/ArgumentPromotion.cpp
lib/Transforms/IPO/GlobalOpt.cpp
lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
lib/Transforms/Scalar/SROA.cpp
lib/Transforms/Utils/CodeExtractor.cpp
lib/Transforms/Utils/DemoteRegToStack.cpp
lib/Transforms/Utils/InlineFunction.cpp
test/Assembler/alloca-addrspace-parse-error-0.ll [new file with mode: 0644]
test/Assembler/alloca-addrspace-parse-error-1.ll [new file with mode: 0644]
test/Assembler/alloca-addrspace0.ll [new file with mode: 0644]
test/Assembler/datalayout-alloca-addrspace-mismatch-0.ll [new file with mode: 0644]
test/Assembler/datalayout-alloca-addrspace-mismatch-1.ll [new file with mode: 0644]
test/Assembler/datalayout-alloca-addrspace-mismatch-2.ll [new file with mode: 0644]
test/Assembler/datalayout-alloca-addrspace.ll [new file with mode: 0644]
test/Assembler/invalid-datalayout-alloca-addrspace.ll [new file with mode: 0644]
test/Transforms/SROA/alloca-address-space.ll [new file with mode: 0644]
tools/llvm-stress/llvm-stress.cpp
unittests/Analysis/ScalarEvolutionTest.cpp