]> granicus.if.org Git - clang/commit
[SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations
authorPavel Labath <labath@google.com>
Fri, 4 Mar 2016 10:00:08 +0000 (10:00 +0000)
committerPavel Labath <labath@google.com>
Fri, 4 Mar 2016 10:00:08 +0000 (10:00 +0000)
commite083b17212302c0abb2b08468df7697839c0841f
tree938913743ce4896e26eb76d682b7031c28a36cdf
parenta6da6f0f080ca28b16e3ba79d0d56dbc873e3b41
[SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

Summary:
While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(), which expect to be
called with a valid source location. This causes an assertion failure if the location is unknown.
A quick grep shows it's not without precedent to guard calls to the function with a
"Loc.isValid()".

This fixes a test failure in LLDB, which always creates object with invalid source locations as it
does not (always) have access to the source.

Reviewers: nlewycky

Subscribers: lldb-commits, cfe-commits

Differential Revision: http://reviews.llvm.org/D17847

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@262700 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Sema/SemaExprCXX.cpp