]> granicus.if.org Git - clang/commit
[coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in...
authorGor Nishanov <GorNishanov@gmail.com>
Sat, 11 Nov 2017 17:00:43 +0000 (17:00 +0000)
committerGor Nishanov <GorNishanov@gmail.com>
Sat, 11 Nov 2017 17:00:43 +0000 (17:00 +0000)
commite017785d9a832d384027edb0bd238a147ba95431
tree26c899dfa805253ecb8ff9f491c90723a62832de
parent3d47fbe0d75b2d1bb5353cc73a9484502860b571
[coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

Summary:
We don't want to store cleanup dest slot saved into the coroutine frame (as some of the cleanup code may
access them after coroutine frame destroyed).

This is an alternative to https://reviews.llvm.org/D37093

It is possible to do this for all functions, but, cursory check showed that in -O0, we get slightly longer function (by 1-3 instructions), thus, we are only limiting cleanup.dest.slot elimination to coroutines.

Reviewers: rjmccall, hfinkel, eric_niebler

Reviewed By: eric_niebler

Subscribers: EricWF, cfe-commits

Differential Revision: https://reviews.llvm.org/D39768

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@317981 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCoroutines/coro-dest-slot.cpp [new file with mode: 0644]